0.1.6 • Published 4 years ago

@immunespace/components v0.1.6

Weekly downloads
34
License
ISC
Repository
github
Last release
4 years ago

@immunespace/components

Defines React components shared between ImmuneSpace modules.

Installation

npm install --save @immunespace/components

This package requires peer dependencies on immutable and react. Any packages which import this package must install them.

Importing components

Example:

import { DropdownButtons } from '@immunespace/components';

You must also import the relevant styles. To import all styles:

@import '~@immunespace/components/dist/scss/index.scss'

What this module includes

Components

src/components

We will include reusable components in here. If you're creating a component for a module and think it could be used in other modules, add it here and to the documentation.

Types

src/types

https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html

  • LabKey
    • LabKey has some parts of their javascript API typed in the @labkey/api package
    • Maybe LabKey will create their own comprehensive type declaration file some day. Until that day, we will keep LabKey-specific types here.
  • ImmuneSpace
    • Types specific to ImmuneSpace that can be shared between modules will also be kept here.

Contributing

First refer to the contribution guide for this repo.

Development process

Refer to the steps in the repo contribution guide for git and versioning workflow. To create a new component named MyComponent:

  1. Create a file src/components/MyComponent.tsx
  2. Define your component and related types in MyComponent.tsx.
  3. Add styles to MyComponent.scss.
  4. Add storybook stories in MyComponent.stories.tsx.
  5. Add jest tests in MyComponent.test.tsx.
  6. Make sure you export your component in index.ts and any related styles in index.scss.

Code structure

Directory Structure

components
├── .storybook/
├── src
│   ├── components/
│   ├── types/
│   ├── index.scss
│   └── index.ts
├── .eslintignore
├── .eslintrc
├── .npmrc
├── .prettierrc
├── README.md
├── jestconfig.json
├── package-lock.json
├── package.json
├── tsconfig.json
└── webpack.config.js

Style Guide

We use Typescript with React. If not specified here, refer to the airbnb style guide

Data Viz

Style/theme

  • Styles specific to any components will be stored in the same directory as the component declarations. So for example, the styles for src/components/greeter.tsx would be in src/components/greeter.scss
  • Use theme variables from @immunespace/theme.

Storybook

npm run storybook

  • Stories for each file are in the same directory as that file. So for example, the tests for src/components/greeter.tsx would be in src/components/greeter.stories.js
  • See this article for some ideas on how to set it up.

Tests

  • Tests for each file are in the same directory as that file. So for example, the tests for src/components/greeter.tsx would be in src/components/greeter.test.tsx.
  • Notes and resources for testing can be found here: Notes for testing React modules