0.8.0 • Published 3 years ago

eslint-plugin-query v0.8.0

Weekly downloads
89
License
MIT
Repository
github
Last release
3 years ago

npm Dependencies devDependencies

Tests badge Coverage badge

Known Vulnerabilities Total Alerts Code Quality: Javascript

Licenses badge

Licenses dev badge

issuehunt-to-marktext

eslint-plugin-query

Add "rules" made of arbitrary selectors to choose source lines to be reported.

Comparison to esquery tool

esquery (demo), a tool used within ESLint, allows queries by AST selector. Here is why we make a separate tool:

  1. Be able to use from the command line
  2. Ability to see the output stringified
  3. Apply to linting if desired as well as querying

Comparison to ESLint no-restricted-syntax rule

While ESLint has a similar rule, this rule differs in that:

  1. You can see the actual syntax in the output if you wish (optionally slicing this output with start and/or end); this makes it ideal for querying data rather than just knowing that some syntax is present in such-and-such a file at such-and-such a line number.
  2. This plugin name suggests it can be used to find items rather than just restrict them (though when used in linting, it indeed serves the purpose of restriction).
  3. You can use arbitrary JavaScript in your template syntax
  4. I hope to expand to other rules for querying (and possibly formatting/sorting results).

Installation

If using as a plugin, you can install locally:

$ npm i eslint-plugin-query --save-dev

However, if you only wish to use this tool to make one-off searches of code, the global installation is recommended as it is more convenient for CLI usage and does not require each project to have its own installation.

You can install globally as follows using the -g flag:

$ npm i -g eslint-plugin-query

Usage

Add query to the plugins section of your .eslintrc configuration file. You can omit the eslint-plugin- prefix:

{
    "plugins": [
        "query"
    ]
}

Then configure the rules you want to use under the rules section.

'use strict';

module.exports = {
  rules: {
    'query/query': [2, {
      queries: {
        'FunctionDeclaration[params.length>4]': {
          // All optional
          // Defaults to just `${result}`
          template: 'Oops, too long: `${result}`.',
          // Default: 0 (also accepts negative)
          start: 0,
          // Default Infinity (also accepts negative)
          end: 100
        }
      }
    }],
    'query/no-missing-syntax': [
      'error',
      {
        queries: {
          'FunctionDeclaration[params.length<2]': {
            message: 'Must have at least two short function signatures!',
            minimum: 2
          }
        }
      }
    ]
  }
};

Supported Rules

  • query/query - Requires a single options object, with:
    • a queries object:
      • Its key should be a string representing the selector.
      • Its value should be an object with the following optional properties:
        • template - A string in the form of an ES6 template (see es6-template-strings). If not present, the result will be used instead. If present, it will be passed the following: - result - The selector-identified node represented as a string (i.e., the lines of code pointed to by the selector)
        • start - An integer at which to begin slicing out of the selected lines of code. May be negative as with slice.
        • end - An integer at which to end slicing out of the selected lines of code. May be negative as with slice.
        • format - May override any defaultFormat (see below).
        • parent - If format is "node", setting this to true will also show the parent properties on the AST. Defaults to false.
    • an optional defaultFormat string ("string" (the default) or "node"). If node is chosen will be represented as stringified Node AST rather than the string found in source.
  • query/no-missing-syntax - Requires a single options object, with:
    • a queries object:
      • Its key should be a string representing the selector.
      • Its value should be an object with the following optional properties:
        • minimum - Minimum requires instances. Defaults to 1.
        • template - A string in the form of an ES6 template (see es6-template-strings). It will be passed the following: - selector - The AST selector. Defaults to Syntax is required: ${selector}.

CLI

It is simpler to use the CLI to get at results (though you'll want to install eslint-plugin-query in such a case):

./docs/sample-query.png

Note that the CLI uses the ESLint formatter, in this case showing them as errors, but as this does no fixing, you can use the esq CLI command simply to see the code (as in the above screenshot).

Note also that in the CLI (and also programmatic) usage, we auto-detect your parser and parser options. However, since we allow you to supply file globs, and since ESLint allows overrides such that you may have different parsers set up in your config, we don't know by default which file to check for the parser config. To ensure the proper parser is used, you can either use the notGlob setting (and use a regular file) or rely on setting an override for the default eslint-plugin-query-dummy.js file (you don't need to have this file in your project, but it allows you to specify an overrides file targeting it and giving a parser or parser options for it).

cli.svg

Tips

Queries into badges

You might use the likes of eslint-formatter-badger to build a badge counting the use of certain JavaScript features out of your results, e.g., if you wanted to show the number of FunctionDeclaration's in your project.

Unless you wish to count the aggregate of total of multiple selectors, you'd probably need to create separate badges for each type (since the eslint-formatter-badger determines type by the whole rule (e.g., from the rule's meta.type) rather than by the rule options (in this case queries) that are in use). Such an approach would allow you to get the individual count for each query type.

You could then display these badges adjacently, optionally with different colors, and with human-readable text (e.g., "Function declarations")), possibly with a plain intro badge before them (e.g., "Language Feature Counts").

One-off searches

Though it is probably just easier to use the CLI, it may be of interest to know that you can use the ESLint binary to make one-off searches, e.g., if you have installed eslint and this plugin globally:

eslint --plugin query --rule 'query/query: [2, {queries: {"FunctionDeclaration[params.length>4]": {end:100}}}]' .

Or if you only have eslint and this plugin as local installs:

$(npm bin)/eslint --plugin query --rule 'query/query: [2, {queries: {"FunctionDeclaration[params.length>4]": {end:100}}}]' .

Here are the results:

query-results.png

Note that you can add the --no-save flag (for local or global use) if you only want to use this plugin for querying in this manner, and not as the basis of permanent rules.

Another use case is ensuring a file or set of files (e.g., within overrides) (or targeted via glob if on the command line) only has one type or a set of types (by using the :not() esquery selector):

$(npm bin)/eslint --plugin query --rule 'query/query: [2, {queries: {":not(FunctionDeclaration,FunctionExpression)": {end:100}}}]' .

To-dos

  1. Could give fixable option (to remove all identified nodes)
  2. Add an option to match (additionally) by regex.
  3. Add an option to highlight certain esqueries out of the results, e.g., to show the list of parameter names of all functions
  4. Get an AST parser for jsdoc comment blocks, e.g., to search for @todo comments, or all functions with a given (jsdoc-described) signature (e.g., all params accepting a given type, all typedefs extending a type, all @public functions, etc. If selectors don't support parent, would be ideal to add support, e.g., to query for parent comment of a given function signature.
  5. Add separate rule for to-do specific querying (date, etc.) see https://github.com/gajus/eslint-plugin-jsdoc/issues/299, https://github.com/sindresorhus/eslint-plugin-unicorn/issues/238, and https://github.com/eslint/eslint/issues/11747.
    1. Would ideally allow sorting (see https://eslint.org/docs/developer-guide/working-with-custom-formatters#using-rule-metadata?)
      1. Note: Could implement with new formatter, and the formatter could be used for other purposes as well (e.g., showing rule errors by meta.type or in this case, by query)
    2. Also lint to ensure even unexpired to-dos have an actual date format (see Unicorn to-do rule). Could use jsdoc/match-description if Unicorn isn't supporting (and option to it to show text of description so can be used in queries, also for other rules like jsdoc/no-undefined-types?).
  6. Might add separate rule using jsdoc blocks in place of selectors, e.g., to find all Date objects, use /** @type {Date} */. Likewise with TypeScript expressions (again, not as much for validation, which TS already does, but for querying documents using TS).
    1. Could make selector which allows such matching, e.g., :matches('jsdoc', '@param {string}\n@param {Date}') or :matches('typescript', '(...args: string[]) => void')
    2. In supporting this, could make utility for compiling jsdoc (or (a subset of) TS) into selectors (and vice versa). Use comment-parser. Could also convert jsdoc to TS by stripping out types and putting inline (as an eslint-plugin-jsdoc rule) or in reverse.
  7. Make combining selectors, e.g., "string" to find string literals or string literals joined in a binary expression, etc. Then can search for a ReturnStatement with string to get the return type.
  8. Allow dir/file glob at beginning of selector, e.g., docs/** IfStatement
  9. Could use es-file-traverse to limit queries to those that are visited by imports (including with "Other interesting use cases" below).
  10. Add separate rules (all supporting range queries) for semver-aware @since or @version, integer-aware @variation, (and date-aware abilities for tags indicated in options (e.g., if one defined @date). Also useful for @license and @copyright searching
  11. Other interesting use cases for selectors (independent of this plugin):
    1. A selector syntax for defining JS syntax highlighters (e.g., FunctionDeclaration {color: green;})
    2. Potentially less brittle monkey-patching
    3. Dynamically evaluating snippets, even private, from within other trusted files (e.g., user templates).
    4. Making links within jsdoc documentation to specific parts of code
    5. Embedding code snippets within Markdown documentation without duplication (e.g., querying for all public method names to generate documentation headings or embed example code).
    6. Using a JS XSLT equivalent to reshape an entire JS file into HTML
    7. Searching for code within an IDE (within or across files)
    8. Create badges showing summary of number of functions, classes, et. along with number of lines of code